Shifted instances: make sure ref_instances is not empty #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correction of another bug introduced by
save_shifted_instances=True
. Hopefully the last one...I had corrected it locally but forgot to include it in the last correction PR #1001.
Loading frames from
self.shifted_instances
,ref_instances
changes and can become an empty list.But the test for
ref_instances
being non-empty was before these lines, therefore the following lines crash becauseref_instances
is unexpectedly an empty list.There are two changes to correct this bug:
self.shifted_instances
above thelen(ref_instances) > 0
test (this is not really needed but it makes the code easier to read).ref_instances
(andref_img
) is modified only if it is not empty.Types of changes